lkml.org 
[lkml]   [2012]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 13/15] drivers/clocksource/cyclone.c: add missing iounmap
    Date
    From: Julia Lawall <Julia.Lawall@lip6.fr>

    Add missing iounmap in error handling code, in a case where the function
    already preforms iounmap on some other execution path.

    A simplified version of the semantic match that finds this problem is as
    follows: (http://coccinelle.lip6.fr/)

    // <smpl>
    @@
    expression e;
    statement S,S1;
    int ret;
    @@
    e = \(ioremap\|ioremap_nocache\)(...)
    ... when != iounmap(e)
    if (<+...e...+>) S
    ... when any
    when != iounmap(e)
    *if (...)
    { ... when != iounmap(e)
    return ...; }
    ... when any
    iounmap(e);
    // </smpl>

    Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

    ---
    drivers/clocksource/cyclone.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/clocksource/cyclone.c b/drivers/clocksource/cyclone.c
    index 72f811f..9e0998f 100644
    --- a/drivers/clocksource/cyclone.c
    +++ b/drivers/clocksource/cyclone.c
    @@ -55,11 +55,11 @@ static int __init init_cyclone_clocksource(void)
    }
    /* even on 64bit systems, this is only 32bits: */
    base = readl(reg);
    + iounmap(reg);
    if (!base) {
    printk(KERN_ERR "Summit chipset: Could not find valid CBAR value.\n");
    return -ENODEV;
    }
    - iounmap(reg);

    /* setup PMCC: */
    offset = base + CYCLONE_PMCC_OFFSET;


    \
     
     \ /
      Last update: 2012-01-12 10:59    [W:0.021 / U:63.664 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site