lkml.org 
[lkml]   [2012]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] gpio/it8761e: Restrict it8761e gpio driver to x86.
Date
On Wed Jan 11 2012 - 14:16:36 EST, Grant Likely wrote:
> This driver does an unconditional read of io space during module init which
> causes a bad dereference on ARM. It looks to me like this is an x86 only
> drivers, so restrict it to only compile on x86.

> config GPIO_IT8761E
> tristate "IT8761E GPIO support"
> + depends on X86
> help
> Say yes here to support GPIO functionality of IT8761E super I/O chip.


Please add a comment to the Kconfig stanza with the reason for the
dependancy so people don't have to be git blame masters to know why
its there.

Something like
depends on X86 # unconditional read of io space during module init

thanks,
milton


\
 
 \ /
  Last update: 2012-01-12 10:25    [from the cache]
©2003-2011 Jasper Spaans