lkml.org 
[lkml]   [2012]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH v3 2/5] pinctrl: add dt binding support for pinmux mappings
On Thu, Jan 12, 2012 at 12:46:52PM -0800, Stephen Warren wrote:
> Shawn Guo wrote at Wednesday, January 11, 2012 8:40 PM:
> > On Wed, Jan 11, 2012 at 10:17:40AM -0800, Stephen Warren wrote:
> ...
> > > So, my position is that:
> > >
> > > * Something (either the pinctrl driver, or the SoC .dtsi file) should
> > > enumerate all available muxable entities that exist in the SoC (pins for
> > > IMX, groups for Tegra).
> >
> > Yes, we enumerate all available pins in pinctrl driver for imx.
> >
> > > * Something (either the pinctrl driver, or the SoC .dtsi file) should
> > > enumerate all the available functions that can be assigned to a muxable
> > > entity.
> >
> > In theory, yes. But I hope you would agree we do not need to
> > necessarily do this for case like imx.
>
> Discussing just the Linux driver internals right now; ignoring device
> tree:
>
> Pinctrl won't let you use a function on a pin/group if that function
> isn't enumerated and doesn't list that pin/group as a valid location
> for that function. Given that, I'm not sure how you can avoid enumerating
> all functions and their legal locations?
>
I agree with you that we should enumerate all available functions in
pinctrl driver, if we want to stick to the original pinctrl subsystem
design. But as you can see, this enumeration for case like imx is
going to be huge data. We would rather have both pingroup and function
defined in respective board file as needed. I know doing so actually
violates the original idea of pinctrl subsystem, and will have data
duplication among different board files. But that's a compromise.
And even Linus.W agreed on this compromise in the thread below.

http://thread.gmane.org/gmane.linux.kernel/1223968/focus=1224470

All above is about non-dt case. For dt case, we will have both pingroup
and function describe in dts, and that's way we are purchasing.

> > For imx6q example, we have 193 pins as the muxable entities, and for
> > each of those pin, there are 8 alternative functions. Let's see what
> > we will have if we enumerate all the available functions for each pin.
> >
> > enum imx6q_pads {
> > IMX6Q_SD2_DAT1 = 0,
> > IMX6Q_SD2_DAT2 = 1,
> > ...
> > IMX6Q_NANDF_D7 = 192,
> > };
> >
> > enum imx6q_pad_sd2_dat1 {
> > IMX6Q_PAD_SD2_DAT1__USDHC2_DAT1 = 0,
> > IMX6Q_PAD_SD2_DAT1__ECSPI5_SS0 = 1,
> > IMX6Q_PAD_SD2_DAT1__WEIM_WEIM_CS_2 = 2,
> > IMX6Q_PAD_SD2_DAT1__AUDMUX_AUD4_TXFS = 3,
> > IMX6Q_PAD_SD2_DAT1__KPP_COL_7 = 4,
> > IMX6Q_PAD_SD2_DAT1__GPIO_1_14 = 5,
> > IMX6Q_PAD_SD2_DAT1__CCM_WAIT = 6,
> > IMX6Q_PAD_SD2_DAT1__ANATOP_ANATOP_TESTO_0 = 7,
> > };
> >
> > enum imx6q_pad_sd2_dat2 {
> > IMX6Q_PAD_SD2_DAT2__USDHC2_DAT2,
> > IMX6Q_PAD_SD2_DAT2__ECSPI5_SS1,
> > IMX6Q_PAD_SD2_DAT2__WEIM_WEIM_CS_3,
> > IMX6Q_PAD_SD2_DAT2__AUDMUX_AUD4_TXD,
> > IMX6Q_PAD_SD2_DAT2__KPP_ROW_6,
> > IMX6Q_PAD_SD2_DAT2__GPIO_1_13,
> > IMX6Q_PAD_SD2_DAT2__CCM_STOP,
> > IMX6Q_PAD_SD2_DAT2__ANATOP_ANATOP_TESTO_1,
> > };
> >
> > ...
> >
> > enum imx6q_pad_nandf_d7 {
> > IMX6Q_PAD_NANDF_D7__RAWNAND_D7,
> > IMX6Q_PAD_NANDF_D7__USDHC2_DAT7,
> > IMX6Q_PAD_NANDF_D7__GPU3D_GPU_DEBUG_OUT_7,
> > IMX6Q_PAD_NANDF_D7__USBOH3_UH2_DFD_OUT_23,
> > IMX6Q_PAD_NANDF_D7__USBOH3_UH3_DFD_OUT_23,
> > IMX6Q_PAD_NANDF_D7__GPIO_2_7,
> > IMX6Q_PAD_NANDF_D7__IPU1_IPU_DIAG_BUS_7,
> > IMX6Q_PAD_NANDF_D7__IPU2_IPU_DIAG_BUS_7,
> > };
> >
> > We simply do not want to over bloat imx6q pinctrl driver with such
> > enumeration.
>
> Yes, I see you'd end up with a huge number of function definitions here.
>
> You may be able to avoid this by changing the way you name/number the
> functions though.
>
> The example above has a unique function name for every individual signal.
> instead, can you name functions based on the controller they connect to?
>
> So, instead of having:
>
> IMX6Q_PAD_SD2_DAT1__USDHC2_DAT1
> IMX6Q_PAD_SD2_DAT2__USDHC2_DAT2
> IMX6Q_PAD_SD2_DAT3__USDHC2_DAT3
> IMX6Q_PAD_SD2_DAT4__USDHC2_DAT4
>
> Can you replace this with a single:
>
> IMX_FUNC_USDHC2
>
So all 'enum imx6q_pad_*' goes away, and instead, we define macros
IMX_FUNC_* at controller basis, correct?

> Where the precise meaning of that function would vary slightly from pad
> to pad; it'd mean "whatever signal from the USDHC2 controller can be
> routed to this pad".
>
> If a given pad could be mux'd to either of 2 (or n) signals from the same
> controller, you may need both IMX_FUNC_USDHC2 and IMX_FUNC_USDHC2_ALT to
> represent this.
>
> Now, you'd also need a table that mapped from (pad, function) to
> mux register value, but at least this would avoid avoid having so many
> function names.
>
> Does this help?
>
Yes, it helps reduce the function names. But I doubt the data we need
to represent will become less anyhow, since we need an extra mapping
table to find mux register value from (pad, function).

> In the Tegra pinctrl patches I posted, I did exactly this.
>
> I guess there is irony here, since I'm arguing elsewhere to make the
> data model as close to the HW as possible, whereas here I'm arguing to
> use a slightly abstract representation for function number rather than
> the raw register mux values.
>
Sometimes, people need compromise :)

> > You may want to suggest we put enumeration of both pins
> > and their functions into dts, so that the pinctrl driver can be clean.
>
> Personally, I'd actually tend to shy away from that; I see little point
> putting this basic essentially static data into the .dts file just to
> parse it back out at boot time into what'll end up being the same tables.
>
The point is that pinctrl driver will not have to accommodate all those
huge amount of data. This is something similar to why we are pushing
common-clk frame work and moving all those clock data into device tree.

> > I'm not sure how that will look like in your mind, but it's something
> > like below in mine.
> >
> > sd2_dat1: pin@0 {
> > alt-functions = < "USDHC2_DAT1"
> > "ECSPI5_SS0"
> > "WEIM_WEIM_CS_2"
> > "AUDMUX_AUD4_TXFS"
> > "KPP_COL_7"
> > "GPIO_1_14"
> > "CCM_WAIT"
> > "ANATOP_ANATOP_TESTO_0" >;
> > };
> >
> > sd2_dat2: pin@1 {
> > alt-functions = < "USDHC2_DAT2"
> > "ECSPI5_SS1"
> > "WEIM_WEIM_CS_3"
> > "AUDMUX_AUD4_TXD"
> > "KPP_ROW_6"
> > "GPIO_1_13"
> > "CCM_STOP"
> > "ANATOP_ANATOP_TESTO_1" >;
> > };
> >
> > We will end up with having 193 such nodes in device tree. I had one
> > patch trying to add pinmux support for imx5 with enumerating every
> > single pin in device tree (That's before pinctrl subsystem is born).
> > The patch concerned Grant a lot with that many nodes in device tree
> > and thus died.
>
> Indeed.
>
> > Besides the above concern, what's the point of enumerating all
> > available functions for each pin at all? The client device will still
> > choose desired function with index/number. See example below ...
>
> As I mentioned above, the pinctrl subsystem currently requires it, since
> the mapping table contains the function name, which it must then convert
> to a function number, and then pass to the pinctrl driver.
>
> As you point out though, this is just error-checking, and if the DT
> were to contain the function number directly (rather than the name),
> the pinctrl subsystem wouldn't have to convert name to number, but
> could just pass the number through to the pinctrl driver. So, in that
> scenario, the complete enumeration is only required for error-checking
> (did someone put something bogus in the DT?). As such, it would be
> technically possible to remove it. What does Linusw think about that?
> Personally, it seems like a bad idea to remove the error checking.
>
I guess this checking still makes sense for non-dt case, where the
mapping table still uses name.

> Removing the error-checking would also require that the DT use the
> raw register mux values, rather than the abstraction I mentioned above.
> Doing anything else would require the table to map from function+pin to
> mux value, i.e. require enumerating all functions.
>
Ideally, DT should just use the raw register mux values, since it's
supposed to describe the raw hardware. But if there is a need of a
mapping between the value DT passes in and the raw hardware mux value,
it should be respective pinctrl driver's job the translate it.

> > > * pinmux properties in device drivers should list the muxable entities
> > > that they use, and the mux function for each of them.
>
> (sorry, s/device drivers/device DT nodes/)
>
> > Following on the example above, we will need something below in SD node
> > to specify each pin and corresponding function selection.
> >
> > usdhc@02194000 { /* uSDHC2 */
> > #pinmux-cells = <2>;
> > // The second cell specify the index of the desired function of given pin
> > pinmux = < &sd2_dat1 0
> > &sd2_dat2 0
> > ... >;
> > status = "okay";
> > };
> >
> > IMO, it's not nice for pinctrl client devices.
>
> What exactly is it not convenient for?
>
I should have said it is not nice/convenient for people who write the
<board>.dts for their boards.

> That DT example seems convenient enough for the person writing the DT
> node for the device; it's a pretty direct representation of how to set
> up the HW. If we allow "virtual" pin groups to be defined by the SoC
> .dtsi file, and have the device DT nodes refer to those by phandle, then
> the content of the referenced DT nodes is going to be roughly exactly
> that same pinmux property, so there's no difference in DT content, just
> the extra complexity of having to look something up by phandle.
>
> That said, as you pointed out, the referenced DT node could be written
> by a SoC vendor, hence perhaps simplifying life for the OEM writing the
> usdhc DT node.
>
That's exactly my point.

> Perhaps what we need is to run cpp on the DT before dtc, so that the
> SoC .dtsi file can define these "predefined" pinmux configurations, and
> device DT nodes can reference them simply, but we don't bloat the .dtb
> with unused "predefined" pinmux nodes, or require phandle parsing:
>
> soc.dtsi:
>
> #define IMX_PMX_USDHC2_A pinmux = < SD2_DAT1 SD2_DAT2 0>;
> #define IMX_PMX_USDHC2_B pinmux = < PINX 4 PINY 7>;
>
> board.dts:
>
> usdhc@02194000 { /* uSDHC2 */
> IMX_PMX_USDHC2_A
> };
>
> That seems to solve all the problems except that we'd need to work out
> how to integrate cpp into dtc.
>
> As far as the device driver goes, I think it's irrelevant. Do note how
> I assume this would work:
>
> The pinctrl subsystem handles all aspects of parsing the pinmux DT value,
> Including converting it to the internal mapping table representation if
> applicable, iterating over the N groups in the value (just like it may
> iterate over n mapping table entries when not using DT) etc.
>
> Drivers call pinmux_get()/pinmux_enable() a single time, just as if the
> pinctrl mapping table were provided through a board file instead of DT.
> Given this, the DT binding doesn't have any impact on how a driver uses
> the pinctrl APIs.
>
The whole idea looks interesting and constructive, but IMHO, it's
unnecessarily complexer than "virtual pingroup" one.

--
Regards,
Shawn


\
 
 \ /
  Last update: 2012-01-13 04:39    [from the cache]
©2003-2011 Jasper Spaans