lkml.org 
[lkml]   [2012]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH] xfs: show uuid when mount fails due to duplicate uuid
On Thu, Jan 12, 2012 at 11:47:20AM +0900, Mitsuo Hayasaka wrote:
> When a system tries to mount a filesystem (FS) using UUID, the xfs
> returns -EINVAL and shows a message if a FS with the same UUID has
> been already mounted. It is useful to output the duplicate UUID
> with it.

Looks good to me,


Reviewed-by: Christoph Hellwig <hch@lst.de>

> - xfs_warn(mp, "Filesystem has duplicate UUID - can't mount");
> + xfs_warn(mp,
> + "Filesystem has duplicate UUID - can't mount: uuid = %pU",
> + uuid);

Maybe we could write this a bit nicer as:

xfs_warn(mp, "Filesystem has duplicate UUID %p - can't mount", uuid);



\
 
 \ /
  Last update: 2012-01-12 17:17    [W:0.064 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site