lkml.org 
[lkml]   [2012]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/6 v2] usb/gadget/pch_udc: Fix disconnect issue
Hello.

On 12-01-2012 6:27, Tomoya MORINAGA wrote:

> ISSUE:
> When the driver notifies a gadget of a disconnect event, a system rarely freezes.

> CAUSE:
> When the driver calls dev->driver->disconnect(), it is not calling spinlock().

spin_unlock(), you mean?

> Signed-off-by: Tomoya MORINAGA<tomoya.rohm@gmail.com>
> ---
> V2: Divide into 6 patches
> ---
> drivers/usb/gadget/pch_udc.c | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)

> diff --git a/drivers/usb/gadget/pch_udc.c b/drivers/usb/gadget/pch_udc.c
> index f222659..a4f8b08 100644
> --- a/drivers/usb/gadget/pch_udc.c
> +++ b/drivers/usb/gadget/pch_udc.c
> @@ -2340,8 +2340,11 @@ static void pch_udc_svc_ur_interrupt(struct pch_udc_dev *dev)
> /* Complete request queue */
> empty_req_queue(ep);
> }
> - if (dev->driver&& dev->driver->disconnect)
> + if (dev->driver&& dev->driver->disconnect) {
> + spin_unlock(&dev->lock);
> dev->driver->disconnect(&dev->gadget);
> + spin_lock(&dev->lock);
> + }

WBR, Sergei


\
 
 \ /
  Last update: 2012-01-12 13:17    [W:0.665 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site