Messages in this thread | | | Date | Thu, 12 Jan 2012 16:12:25 +0400 | From | Sergei Shtylyov <> | Subject | Re: [PATCH 1/6 v2] usb/gadget/pch_udc: Fix disconnect issue |
| |
Hello.
On 12-01-2012 6:27, Tomoya MORINAGA wrote:
> ISSUE: > When the driver notifies a gadget of a disconnect event, a system rarely freezes.
> CAUSE: > When the driver calls dev->driver->disconnect(), it is not calling spinlock().
spin_unlock(), you mean?
> Signed-off-by: Tomoya MORINAGA<tomoya.rohm@gmail.com> > --- > V2: Divide into 6 patches > --- > drivers/usb/gadget/pch_udc.c | 5 ++++- > 1 files changed, 4 insertions(+), 1 deletions(-)
> diff --git a/drivers/usb/gadget/pch_udc.c b/drivers/usb/gadget/pch_udc.c > index f222659..a4f8b08 100644 > --- a/drivers/usb/gadget/pch_udc.c > +++ b/drivers/usb/gadget/pch_udc.c > @@ -2340,8 +2340,11 @@ static void pch_udc_svc_ur_interrupt(struct pch_udc_dev *dev) > /* Complete request queue */ > empty_req_queue(ep); > } > - if (dev->driver&& dev->driver->disconnect) > + if (dev->driver&& dev->driver->disconnect) { > + spin_unlock(&dev->lock); > dev->driver->disconnect(&dev->gadget); > + spin_lock(&dev->lock); > + }
WBR, Sergei
| |