lkml.org 
[lkml]   [2012]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
Subjectaacraid question: is maximum_num_containers supposed to be minimum?
MAXIMUM_NUM_CONTAINERS is consistently used as a minimum not a maximum
so I was wondering what was up with that? This is ancient code that
predates git.

drivers/scsi/aacraid/aachba.c
382 if (maximum_num_containers < MAXIMUM_NUM_CONTAINERS)
383 maximum_num_containers = MAXIMUM_NUM_CONTAINERS;
384 fsa_dev_ptr = kzalloc(sizeof(*fsa_dev_ptr) * maximum_num_containers,
385 GFP_KERNEL);

Btw, if maximum_num_containers were really a maximum instead of minimum
then it should be unsigned. That was what brought the code to my
attention initially.

drivers/scsi/aacraid/linit.c
1235 if (shost->max_id < MAXIMUM_NUM_CONTAINERS)
1236 shost->max_id = MAXIMUM_NUM_CONTAINERS;
1237 else
1238 shost->this_id = shost->max_id;

regards,
dan carpenter



\
 
 \ /
  Last update: 2012-01-11 09:31    [W:0.070 / U:0.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site