lkml.org 
[lkml]   [2012]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Makefiles: Disable unused-variable warning
    On Sun 08-01-12 16:01:17, Michal Marek wrote:
    > Dne 27.12.2011 14:57, Michal Hocko napsal(a):
    > > Anyway, I am wondering why unused-but-set-variable is disabled while
    > > unused-variable is enabled.
    >
    > unused-but-set-variable was disabled, because it was a new warning in
    > gcc 4.6 and produced too much noise relatively to its severity. A make
    > W=1 build of x86_64_defconfig gives:
    > $ grep -c 'Wunused-but-set-variable' log
    > 77
    > $ grep -c 'Wunused-variable' log
    > 0
    >
    > More exotic configuration will probably result in a couple of unused
    > variable warnings, but that IMO no reason to disable them globally.

    OK.

    > > Shouldn't we just disable it as well rather
    > > than workaround this in the code? The warning is just pure noise in this
    > > case.
    >
    > If it's noise in a particular case, there is always the option to add
    >
    > CFLAGS_memcontrol.o := $(call cc-disable-warning, unused-variable)

    I would like to prevent from local cflags hacks. Moreover the code will
    go away so I guess it doesn't make much sense to play tricks here.

    >
    > to the respective Makefile.
    >
    > Michal

    Thanks

    --
    Michal Hocko
    SUSE Labs
    SUSE LINUX s.r.o.
    Lihovarska 1060/12
    190 00 Praha 9
    Czech Republic


    \
     
     \ /
      Last update: 2012-01-10 09:55    [W:0.024 / U:0.384 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site