lkml.org 
[lkml]   [2012]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[20/20] xfs: fix acl count validation in xfs_acl_from_disk()
    2.6.32-longterm review patch.  If anyone has any objections, please let me know.

    ------------------
    From: Xi Wang <xi.wang@gmail.com>

    commit 093019cf1b18dd31b2c3b77acce4e000e2cbc9ce upstream.

    Commit fa8b18ed didn't prevent the integer overflow and possible
    memory corruption. "count" can go negative and bypass the check.

    Signed-off-by: Xi Wang <xi.wang@gmail.com>
    Reviewed-by: Christoph Hellwig <hch@lst.de>
    Signed-off-by: Ben Myers <bpm@sgi.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    fs/xfs/linux-2.6/xfs_acl.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)
    --- a/fs/xfs/linux-2.6/xfs_acl.c
    +++ b/fs/xfs/linux-2.6/xfs_acl.c
    @@ -37,7 +37,7 @@ xfs_acl_from_disk(struct xfs_acl *aclp)
    struct posix_acl_entry *acl_e;
    struct posix_acl *acl;
    struct xfs_acl_entry *ace;
    - int count, i;
    + unsigned int count, i;

    count = be32_to_cpu(aclp->acl_cnt);
    if (count > XFS_ACL_MAX_ENTRIES)



    \
     
     \ /
      Last update: 2012-01-10 21:15    [W:0.181 / U:0.908 seconds]
    ©2003-2014 Jasper Spaans. Advertise on this site