lkml.org 
[lkml]   [2012]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 6/6] dma/imx-sdma: check whether event_id0 < 32 when set event_mask
    On Tue, Jan 10, 2012 at 10:29:42PM +0800, Richard Zhao wrote:
    > On Tue, Jan 10, 2012 at 10:20:10PM +0800, Shawn Guo wrote:
    > > On Tue, Jan 10, 2012 at 03:01:50PM +0800, Richard Zhao wrote:
    > > > Signed-off-by: Richard Zhao <richard.zhao@linaro.org>
    > > > ---
    > >
    > > I think it deserves a sensible commit message explaining why the patch
    > > is needed.
    > If event_id0 < 32, 1 << (sdmac->event_id0 - 32) is not zero.
    >
    My point is you may explain the exact problem you are seeing without
    this patch and how the patch helps here. In general, doing so would
    win a warm feeling from reviewers much more easily than leaving the
    commit message empty there.

    --
    Regards,
    Shawn


    \
     
     \ /
      Last update: 2012-01-10 16:31    [W:0.019 / U:30.800 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site