lkml.org 
[lkml]   [2011]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v2] ASoC: omap: convert per-board modules to platform drivers
    From
    On 9 September 2011 05:29, Mark Brown
    <broonie@opensource.wolfsonmicro.com> wrote:
    > Jassi's suggestion was that we should have some magic to
    > automatically generate defaults for the relevant device registrations to
    > sidestep these issues.
    Perhaps there is some misunderstanding.... no witchcraft is involved here.
    To be clear, I suggested moving platform_device definition and registration
    from 12 board files to some common platform file and use machine_is_xxx()
    to assign names of those platform devices. Btw, omap_init_audio() is already
    called from an arch_initcall.
    Also please note that currently there's no platform_data needed to be passed.
    If that requirement arise in future, an optional set_asoc_platdata(void *pdata)
    could be defined beside platform_device creation.
    While the idea is not absolutely good, imho, it's certainly an improvement
    over this patch. Or am I overlooking something ?


    \
     
     \ /
      Last update: 2011-09-09 10:51    [W:0.020 / U:92.292 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site