Messages in this thread |  | | | Date | Fri, 9 Sep 2011 17:41:38 -0700 | | From | Greg KH <> | | Subject | Re: [PATCH 4/5] zram: Simplify zram disk resizing interface |
| |
On Fri, Sep 09, 2011 at 08:12:49PM -0400, Nitin Gupta wrote: > On 09/09/2011 07:11 PM, Greg KH wrote: > > > "simplify" it in what way? > > > > What just got changed, and why, and did it just break any documentation? > > > > > Its simplification in the sense that earlier we had to be pass total RAM > size in bytes when setting zram disksize using zram_set_disksize() > which is not intuitive. The replaced version instead just requires > the new size to be set which seems to make more sense.
Then why not mention that?
Is there some character limit in the changelog comment section that I don't know about? :)
Please, be much more descriptive so we have a chance to know what is going on.
> The first message is no longer required since we now set some default > value (25% of RAM) instead of zero. So, if user doesn't provide any > disksize value, we use the default. > > The second message really doesn't belong in a kernel driver. That's more > of a documentation or user commonsense thing. If a user really thinks > that the data to be written is going to be highly compressible, setting > zram to such large value makes some sense and there is little point in > throwing out this big warning in system logs.
Again, put this in the changelog...
greg k-h
|  |