lkml.org 
[lkml]   [2011]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 05/25] Staging: hv: vmbus: Change the signature of struct hv_driver probe function
On Thu, Sep 08, 2011 at 07:24:16AM -0700, K. Y. Srinivasan wrote:
> --- a/drivers/staging/hv/vmbus_drv.c
> +++ b/drivers/staging/hv/vmbus_drv.c
> @@ -299,9 +299,15 @@ static int vmbus_probe(struct device *child_device)
> struct hv_driver *drv =
> drv_to_hv_drv(child_device->driver);
> struct hv_device *dev = device_to_hv_device(child_device);
> + const struct hv_vmbus_device_id *dev_id = drv->id_table;
> +
> + for (; !is_null_guid(dev_id->guid); dev_id++)
> + if (!memcmp(&dev_id->guid, &dev->dev_type.b,
> + sizeof(uuid_le)))
> + break;

Don't duplicate this section of code twice (at least) in the driver.
Make it a "vmbus_match_device()" function that returns the proper
hv_vmbus_device_id * to do something with.

thanks,

greg k-h


\
 
 \ /
  Last update: 2011-09-09 22:51    [W:0.147 / U:0.436 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site