lkml.org 
[lkml]   [2011]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 1/2] arm: omap: usb: enable I/O wakeups of ehci and ohci hwmods of omap4
    Date
    Keshava Munegowda <keshava_mgowda@ti.com> writes:

    > From: Kishon Vijay Abraham <kishon@ti.com>
    >
    > For ehci and ohci hwmods, the omap4 I/O wakeup capablity is enabled.
    > for ehci in phy mode,
    > - the DAT0 and DIR I/O pad is set as wakeup capable
    > for ohci in serial mode
    > - usbb*_mm_rxdp is set as I/O wakeup for 6 pin serial mode
    > - usbb*_mm_rxrcv is set as I/O wakeup for 4 pin serial mode
    > - usbb*_mm_txen is set as I/O wakeup for 3 pin serial mode
    > - usbb*_mm_txdat is set as I/O wakeup for 2 pin serial mode
    >
    > Signed-off-by: Kishon Vijay Abraham <kishon@ti.com>
    > Signed-off-by: Keshava Munegowda <keshava_mgowda@ti.com>

    What if the end user doesn't want this device to be a wakeup source?

    Currently, the IO pad wakeup for these pins is enabled unconditionally.
    While having it enabled as a wakeup source by default is fine, it should
    not generate wakeups if the user has disable them by doing:

    $ echo disabled > /sys/devices/.../power/wakeup

    IOW, whether wakeups are enabled or not should depend on the driver
    checking device_may_wakeup()

    Kevin


    \
     
     \ /
      Last update: 2011-09-09 20:29    [W:0.021 / U:31.912 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site