lkml.org 
[lkml]   [2011]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH tip/core/rcu 19/55] rcu: Move RCU_BOOST declarations to allow compiler checking
    Date
    From: Paul E. McKenney <paul.mckenney@linaro.org>

    Andi Kleen noticed that one of the RCU_BOOST data declarations was
    out of sync with the definition. Move the declarations so that the
    compiler can do the checking in the future.

    Signed-off-by: Paul E. McKenney <paul.mckenney@linaro.org>
    Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
    ---
    kernel/rcutree.h | 7 +++++++
    kernel/rcutree_trace.c | 5 -----
    2 files changed, 7 insertions(+), 5 deletions(-)

    diff --git a/kernel/rcutree.h b/kernel/rcutree.h
    index 01b2ccd..eee6c94 100644
    --- a/kernel/rcutree.h
    +++ b/kernel/rcutree.h
    @@ -417,6 +417,13 @@ extern struct rcu_state rcu_preempt_state;
    DECLARE_PER_CPU(struct rcu_data, rcu_preempt_data);
    #endif /* #ifdef CONFIG_TREE_PREEMPT_RCU */

    +#ifdef CONFIG_RCU_BOOST
    +DECLARE_PER_CPU(unsigned int, rcu_cpu_kthread_status);
    +DECLARE_PER_CPU(int, rcu_cpu_kthread_cpu);
    +DECLARE_PER_CPU(unsigned int, rcu_cpu_kthread_loops);
    +DECLARE_PER_CPU(char, rcu_cpu_has_work);
    +#endif /* #ifdef CONFIG_RCU_BOOST */
    +
    #ifndef RCU_TREE_NONCORE

    /* Forward declarations for rcutree_plugin.h */
    diff --git a/kernel/rcutree_trace.c b/kernel/rcutree_trace.c
    index 8827b34..e623564 100644
    --- a/kernel/rcutree_trace.c
    +++ b/kernel/rcutree_trace.c
    @@ -48,11 +48,6 @@

    #ifdef CONFIG_RCU_BOOST

    -DECLARE_PER_CPU(unsigned int, rcu_cpu_kthread_status);
    -DECLARE_PER_CPU(int, rcu_cpu_kthread_cpu);
    -DECLARE_PER_CPU(unsigned int, rcu_cpu_kthread_loops);
    -DECLARE_PER_CPU(char, rcu_cpu_has_work);
    -
    static char convert_kthread_status(unsigned int kthread_status)
    {
    if (kthread_status > RCU_KTHREAD_MAX)
    --
    1.7.3.2


    \
     
     \ /
      Last update: 2011-09-07 08:27    [W:3.526 / U:0.732 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site