lkml.org 
[lkml]   [2011]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 0/10] IOMMU: Make iommu_ops per-bus_type
    On Wed, Sep 07, 2011 at 05:41:43PM +0200, Joerg Roedel wrote:
    > Hi,
    >
    > here is the new version of the patch-set to make the iommu_ops used in
    > the iommu-api a bus_type property. This will allow us to move code out
    > of the iommu drivers into generic code and it simplifies the
    > implementation of the Alex' device-group property.
    >
    > Greg, can you have a look at patch 2 please and tell me if you have any
    > objections?

    I object, please see my comments.

    > With this version the patch-set is complete (not as the first RFC post).
    > It converts all iommu drivers to use the new registration interface and
    > completly removes the register_iommu interface.
    >
    > Regards,
    >
    > Joerg
    >
    > Diffstat:
    >
    > arch/ia64/kvm/kvm-ia64.c | 3 +-
    > arch/x86/kvm/x86.c | 3 +-
    > drivers/base/bus.c | 16 ++++++++++
    > drivers/iommu/amd_iommu.c | 2 +-
    > drivers/iommu/intel-iommu.c | 2 +-
    > drivers/iommu/iommu.c | 58 ++++++++++++++++++++++++------------
    > drivers/iommu/msm_iommu.c | 2 +-
    > drivers/iommu/omap-iommu.c | 2 +-
    > drivers/media/video/omap3isp/isp.c | 2 +-
    > include/linux/device.h | 9 +++++
    > include/linux/iommu.h | 21 +++++++------
    > virt/kvm/iommu.c | 4 +-
    > 12 files changed, 86 insertions(+), 38 deletions(-)

    So the overall work here makes for more code, right? I fail to see the
    benifit, what am I missing?

    greg k-h


    \
     
     \ /
      Last update: 2011-09-07 20:51    [W:4.291 / U:0.600 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site