Messages in this thread | | | Date | Tue, 6 Sep 2011 12:08:57 +0200 | From | Robert Richter <> | Subject | Re: [V3][PATCH 2/6] x86, nmi: create new NMI handler routines |
| |
On 25.08.11 12:45:44, Don Zickus wrote: > +int register_nmi_handler(unsigned int type, nmi_handler_t handler, > + unsigned long nmiflags, const char *devname) > +{ > + struct nmiaction *action; > + int retval; > + > + if (!handler) > + return -EINVAL; > + > + action = kzalloc(sizeof(struct nmiaction), GFP_KERNEL); > + if (!action) > + return -ENOMEM; > + > + action->handler = handler; > + action->flags = nmiflags; > + action->name = kstrndup(devname, NMI_MAX_NAMELEN, GFP_KERNEL);
Null pointer check is missing here.
> + > + retval = __setup_nmi(type, action); > + > + if (retval) { > + kfree(action->name); > + kfree(action); > + } > + > + return retval; > +} > +EXPORT_SYMBOL_GPL(register_nmi_handler);
-- Advanced Micro Devices, Inc. Operating System Research Center
| |