lkml.org 
[lkml]   [2011]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] ASoC: Allow codecs to provide their own regmap configuration
On Mon, Sep 05, 2011 at 03:18:01PM +0200, Lars-Peter Clausen wrote:
> Currently a codec can either do the whole regmap initialization on its own or
> provide only the register and value bit size and let the core handle
> initialization. This patch allows a codec to provide a complete regmap
> configuration while still letting ASoC core handle the regmap initialization
> and setup.

I'd rather not do this, the only value is the copying of the word size
setup out of the regmap config is to allow us to use the ASoC cache code
but the idea is to push the cache down out of ASoC into the regmap code
so this function should just be a trivial indirection for the regmap
init which isn't useful.

> - * Register formats are frequently shared between many I2C and SPI
> - * devices. In order to promote code reuse the ASoC core provides
> - * some standard implementations of CODEC read and write operations
> - * which can be set up using this function.
> - *
> - * The caller is responsible for allocating and initialising the
> - * actual cache.
> - *
> - * Note that at present this code cannot be used by CODECs with
> - * volatile registers.
> + * Legacy and convenience wrapper around snd_soc_codec_regmap_init
> */

This is a useful but unrelated change.


\
 
 \ /
  Last update: 2011-09-05 19:33    [from the cache]
©2003-2011 Jasper Spaans