Messages in this thread |  | | | Date | Mon, 5 Sep 2011 03:11:39 +0900 | | From | Tejun Heo <> | | Subject | Re: [PATCH 1/6] cgroup_freezer: fix freezer->state setting bug in freezer_change_state() |
| |
On Sun, Sep 04, 2011 at 08:02:06PM +0200, Oleg Nesterov wrote: > Cough. Now it doesn't look right to me ;) > > If the user write "FROZEN" into the control file, we should not > turn the CGROUP_FROZEN state into CGROUP_FREEZING. Probably this > is harmless, but this looks wrong and this doesn't match the > current behaviour, user-visible change.
It's not user-visible as the state is always updated before shown to userland. If we're gonna be re-priming freezing on each FROZEN write, resetting the state to freezing to force state re-calculation is logical thing to do.
Thanks.
-- tejun
|  |