[lkml]   [2011]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] workqueue: Restore cpus_allowed mask for sleeping workqueue rescue threads
    On Fri, Sep 30, 2011 at 09:54:21AM +0100, Ripduman Sohan wrote:
    > Tejun Heo <> wrote:
    > > Hmmm... indeed. This can cause an unnecessary wakeup / migration on
    > > an isolated CPU when another CPU asks for the rescuer, so yeah it
    > > makes sense to change the behavior. BTW, why didn't the original
    > > patch simply use set_cpus_allowed_ptr(cpu_all_mask)?
    > >
    > Because while at present all (bound) rescuer threads have an
    > associated workqueue on each CPU, I didn't want to assume this
    > arrangement would _always_ be the case. It was my thinking that for
    > bound threads, iterating over the CPUs to only set those that have
    > an associated workqueue for the rescuer would insulate agsinst any
    > future case where rescuer threads may be bound to a subset of CPUs.

    On which CPU a rescuer is doesn't matter at all. Using cpu_all_mask
    is good enough.

    Thank you.


     \ /
      Last update: 2011-09-30 10:59    [W:0.019 / U:2.872 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site