Messages in this thread | | | From | Bjorn Helgaas <> | Date | Fri, 30 Sep 2011 16:50:13 -0600 | Subject | Re: [099/244] PCI: Set PCI-E Max Payload Size on fabric |
| |
On Fri, Sep 30, 2011 at 4:40 PM, Jon Mason <mason@myri.com> wrote: > > On Fri, Sep 30, 2011 at 5:33 PM, Bjorn Helgaas <bhelgaas@google.com> wrote: > > On Wed, Sep 28, 2011 at 4:01 PM, Greg KH <gregkh@suse.de> wrote: > >> 3.0-stable review patch. If anyone has any objections, please let us know. > > > > I object to this :) I think the following patches should be omitted > > from -stable: > > > > [099/244] PCI: Set PCI-E Max Payload Size on fabric > > [100/244] PCI: export pcie_bus_configure_settings symbol > > [101/244] PCI: Remove MRRS modification from MPS setting code > > [212/244] pci: Dont crash when reading mpss from root complex > > > > I've heard rumors that these patches are required to make 3.0 boot on > > some machines, but I don't really believe it, and I haven't seen the > > problem reports myself. > > Would it be acceptable to disable MPS modification by default (as you > have been suggesting for 3.1) and have the machines who are having the > boot issues pass a boot parm to enable the MPS modification?
I'm OK with 3.1 having MPS modification disabled by default, but having a command line switch to enable it.
Should that same thing go in 3.0-stable? I dunno. My first reaction is "No, because I still don't have a concrete problem report that says it fixes anything." I can't tell if these are secret machines, people thinking the 3.1-rcX regressions are a problem in 3.0, or what.
Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |