lkml.org 
[lkml]   [2011]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectCIFS kernel module bug
    From
    Date
    Hi,

    Looking at the current kernel (in Linus' repository on github) there is a silly logic bug in the cifs module in fs/cifs/cifsfs.c::cifs_llseek() there is this bit of code:

    /*
    * origin == SEEK_END || SEEK_DATA || SEEK_HOLE => we must revalidate
    * the cached file length
    */
    if (origin != SEEK_SET || origin != SEEK_CUR) {

    The logical or should be a logical and, i.e. this should be:

    if (origin != SEEK_SET && origin != SEEK_CUR) {

    As the code is at present that line is ALWAYS true because origin is ALWAYS either != SEEK_SET or != SEEK_CUR as if it equals one it cannot equal the other and vice versa…

    So at the moment it always does the revalidation instead of only for SEEK_END, SEEK_DATA, and SEEK_HOLE.

    Best regards,

    Anton
    --
    Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
    Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK
    Linux NTFS maintainer, http://www.linux-ntfs.org/

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-09-30 16:01    [W:0.019 / U:62.732 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site