Messages in this thread | | | Date | Sat, 3 Sep 2011 13:36:11 +0100 | From | Matthew Garrett <> | Subject | Re: [PATCH 2/2] pstore: update the policy of the UEFI-based backend |
| |
I don't think this is reasonable. EFI variable space is a shared resource. We have no idea what the failure modes of entirely filling it would be. If we're going to store multiple records then at the very least we need to use QueryVariableInfo() to identify how much space there is left, and if it's a 2.1 or later system then we ideally need to store these as EFI_VARIABLE_HARDWARE_ERROR_RECORD rather than just plain runtime variables. The reason the current implementation doesn't do that is that there's still hardware floating around that implements EFI 1.10 rather than UEFI 2.0
-- Matthew Garrett | mjg59@srcf.ucam.org
| |