Messages in this thread | | | Date | Sat, 3 Sep 2011 11:46:41 +0100 | From | Alan Cox <> | Subject | Re: [PATCH] vt_ioctl.c: fix compile error with pm_set_vt_switch() |
| |
On Fri, 2 Sep 2011 14:02:42 -0700 H Hartley Sweeten <hartleys@visionengravers.com> wrote:
> When CONFIG_PM_SLEEP, CONFIG_VT, and CONFIG_VT_CONSOLE are not enabled > the function pm_set_vt_switch() is defined as an inline in linux/suspend.h. This causes > a compile error if CONFIG_VT is enabled. > > drivers/tty/vt/vt_ioctl.c:1794: error: redefinition of 'pm_set_vt_switch' > include/linux/suspend.h:17: error: previous definition of 'pm_set_vt_switch' was here > > Fix this with an #if defined guard around the function in vt_ioctl.c.
Can you put the #if uglies into the buggy suspend.h header instead so the code proper is kept clean of ifdefs.
Alan
| |