lkml.org 
[lkml]   [2011]   [Sep]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/3] Input: cyttsp - Cypress TTSP capacitive multi-touch screen support
From
Date
Hello Dmitry,

On Sun, 2011-08-21 at 21:31 -0700, Dmitry Torokhov wrote:
> Hi Javier,

>
> Still reading through the patches, but have one question:
>
> > +
> > + ts->irq = gpio_to_irq(ts->platform_data->irq_gpio);
> > + if (ts->irq <= 0) {
> > + dev_dbg(ts->dev, "%s: Error, failed to allocate irq\n",
> > + __func__);
> > + goto error_init;
> > + }
>
> Why do we need to get gpio/irq from platform data instead of having
> board code set up controllers appropriately and use IRQ either from I2C
> client structure or from SPI?
>
> Thanks.
>

Right, next version fix this by extracting the IRQ either from the I2C
or SPI client data structure as you suggest.

Best regards,

Javier Martinez Canillas



\
 
 \ /
  Last update: 2011-09-03 07:37    [W:0.043 / U:0.192 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site