lkml.org 
[lkml]   [2011]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 08/10] iommu/omap: Use bus_set_iommu instead of register_iommu
On Fri, Sep 23, 2011 at 05:45:54PM +0200, Joerg Roedel wrote:
> Convert the OMAP IOMMU driver on ARM to use the new
> interface for publishing the iommu_ops.
>
> Cc: Ohad Ben-Cohen <ohad@wizery.com>
> Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
> ---
> drivers/iommu/omap-iommu.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c
> index bd5f606..16d5b76 100644
> --- a/drivers/iommu/omap-iommu.c
> +++ b/drivers/iommu/omap-iommu.c
> @@ -1250,7 +1250,7 @@ static int __init omap_iommu_init(void)
> return -ENOMEM;
> iopte_cachep = p;
>
> - register_iommu(&omap_iommu_ops);
> + bus_set_iommu(&platform_bus_type, &omap_iommu_ops);

I too worry about this.

It kind of looks like the omap code should not be using the platform bus
code for this, but instead, use their own bus code, as I'm sure that not
all platform devices really work properly with this iommu controller,
right?

thanks,

greg k-h


\
 
 \ /
  Last update: 2011-09-29 22:11    [from the cache]
©2003-2011 Jasper Spaans