lkml.org 
[lkml]   [2011]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] dm: verity target
Valdis.Kletnieks@vt.edu (Valdis.Kletnieks@vt.edu) wrote:
> On Tue, 27 Sep 2011 14:02:05 CDT, Will Drewry said:
>
> > I was just curious if there is any interest in pulling this change, or
> > if not, if there is any particular set of concerns, fixes, etc.
>
> Out of curiosity, how much of the stack does this end up eating? My root
> filesystem is already ext4 on an LVM partition that's on a LUKS/dm-crypt
> partition on a hard drive, and I'm sure somebody out there will have used xfs
> instead - and then exported it via NFS or something. Are we going to get weird
> stack overflows if people throw dm-verity into this sort of mix?
>

No. dm-verity uses very little stack since most of the code is running
in a separate workqueue context. The _map call is pretty light.

> > realize it's not a small amount of code to digest (though it is
> > smaller than the post from last year[1]). Would re-posting with an
> > added blob explaining the name be useful,
>
> Probably will need it to be merged, unless you set up an auto-reply that says
> "Patch rejected, 'verity' is *not* a typo for 'verify'" ;)
>
> I'll hopefully have some more comments over the weekend if I get some spare
> cycles.
>


\
 
 \ /
  Last update: 2011-09-29 19:33    [W:0.194 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site