lkml.org 
[lkml]   [2011]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] ASoC: Add BUG() assertion if max98088_get_channel returns -EINVAL
    On Thu, Sep 29, 2011 at 09:15:03AM +1000, Ryan Mallon wrote:
    > On 29/09/11 00:01, Axel Lin wrote:
    > > The callers use the return value of max98088_get_channel as array index to
    > > access max98088->dai[] array.
    > > Add BUG() assertion for out of bound access of max98088->dai[] array.

    > BUG() is pretty heavy handed for a driver. Why not fix the problem
    > properly in the callers?

    There's nothing constructive that any of the callers can do with an
    error code - it's a clear bug in something (probably the driver) if we
    get called for a bad control. Simply returning an error code isn't
    terribly helpful, it's very obscure what's gone wrong and why. We at
    least need a log message.


    \
     
     \ /
      Last update: 2011-09-29 12:37    [W:0.019 / U:0.760 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site