lkml.org 
[lkml]   [2011]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[059/244] alarmtimers: Avoid possible denial of service with high freq periodic timers
    3.0-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: John Stultz <john.stultz@linaro.org>

    commit 6af7e471e5a7746b8024d70b4363d3dfe41d36b8 upstream.

    Its possible to jam up the alarm timers by setting very small interval
    timers, which will cause the alarmtimer subsystem to spend all of its time
    firing and restarting timers. This can effectivly lock up a box.

    A deeper fix is needed, closely mimicking the hrtimer code, but for now
    just cap the interval to 100us to avoid userland hanging the system.

    CC: Thomas Gleixner <tglx@linutronix.de>
    Signed-off-by: John Stultz <john.stultz@linaro.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    kernel/time/alarmtimer.c | 9 +++++++++
    1 file changed, 9 insertions(+)

    --- a/kernel/time/alarmtimer.c
    +++ b/kernel/time/alarmtimer.c
    @@ -481,6 +481,15 @@ static int alarm_timer_set(struct k_itim
    if (!rtcdev)
    return -ENOTSUPP;

    + /*
    + * XXX HACK! Currently we can DOS a system if the interval
    + * period on alarmtimers is too small. Cap the interval here
    + * to 100us and solve this properly in a future patch! -jstultz
    + */
    + if ((new_setting->it_interval.tv_sec == 0) &&
    + (new_setting->it_interval.tv_nsec < 100000))
    + new_setting->it_interval.tv_nsec = 100000;
    +
    if (old_setting)
    alarm_timer_get(timr, old_setting);




    \
     
     \ /
      Last update: 2011-09-29 01:29    [W:0.021 / U:0.252 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site