Messages in this thread | | | Date | Wed, 28 Sep 2011 14:16:49 -0400 | From | Christoph Hellwig <> | Subject | Re: [GIT PULL] Queue free fix (was Re: [PATCH] block: Free queue resources at blk_release_queue()) |
| |
On Wed, Sep 28, 2011 at 02:09:05PM -0400, Vivek Goyal wrote: > I had thought of implementing a separate lock for throttling. Then I > noticed few operations like checking for queue flags where I would > be required to hold queue locks.
Can you do a writeup of these issues? E.g. if the flags are throtteling specific we can move them to a separate flags field, if not we can see if we can make them atomic or similar.
Right now on high iops device queue_lock is the major killer for performance. It's one major reason (*) why a lot of the high iops devices are all moving to ->make_request, which has other issues.
(*) others are struct request allocation and the pointless merge hash
| |