lkml.org 
[lkml]   [2011]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH V5] mtd: Add DiskOnChip G3 support
    From
    Date
    On Fri, 2011-09-23 at 21:14 +0200, Robert Jarzmik wrote:
    > Add support for DiskOnChip G3 chips. The support is quite
    > limited yet :
    > - no flash writes/erases are implemented
    > - ECC fixes are not implemented
    > - powerdown is not implemented
    > - IPL handling is not yet done
    >
    > On the brighter side, the chip reading does work.
    >
    > Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>

    Sparse complains:

    [dedekind@sauron l2-mtd-2.6 (master)]$ make C=1
    CHK include/linux/version.h
    CHK include/generated/utsrelease.h
    CALL scripts/checksyscalls.sh
    CHK include/generated/compile.h
    CHECK drivers/mtd/devices/docg3.c
    drivers/mtd/devices/docg3.h:217:21: error: dubious one-bit signed bitfield

    And indeed:

    int device_id:4;
    int if_cfg:1;

    should be unsigned int bit-fields, not signed.

    --
    Best Regards,
    Artem Bityutskiy



    \
     
     \ /
      Last update: 2011-09-27 14:57    [W:3.137 / U:0.652 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site