Messages in this thread | | | Date | Tue, 27 Sep 2011 07:41:57 -0500 | From | "Serge E. Hallyn" <> | Subject | Re: [PATCH 2/2] user namespace: usb: make usb urbs user namespace aware (v2) |
| |
Quoting Greg KH (greg@kroah.com): > On Mon, Sep 26, 2011 at 10:45:18AM -0500, Serge Hallyn wrote: > > Add to the dev_state and alloc_async structures the user namespace > > corresponding to the uid and euid. Pass these to kill_pid_info_as_uid(), > > which can then implement a proper, user-namespace-aware uid check. > > > > Changelog: > > Sep 20: Per Oleg's suggestion: Instead of caching and passing user namespace, > > uid, and euid each separately, pass a struct cred. > > Sep 26: Address Alan Stern's comments: don't define a struct cred at > > usbdev_open(), and take and put a cred at async_completed() to > > ensure it lasts for the duration of kill_pid_info_as_cred(). > > > > Signed-off-by: Serge Hallyn <serge.hallyn@canonical.com> > > Cc: Greg KH <greg@kroah.com> > > I have no objection to this, is it going to go through your tree, or > somewhere else?
(Silly question from me, but just to make sure - were you asking this of Alan?)
> If so, please add: > Acked-by: Greg Kroah-Hartman <gregkh@suse.de> > to it.
Thanks, -serge
| |