lkml.org 
[lkml]   [2011]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] tty/n_gsm: fix a bug in gsm_dlci_data_output (adaption = 2 case)
On Fri, 23 Sep 2011 19:22:55 +0400
Mikhail Kshevetskiy <mikhail.kshevetskiy@gmail.com> wrote:

> in adaption=2 case we should put 1 or 2 byte with modem status bits
> at the beginning of a buffer pointed by "dp". n_gsm use 1 byte case,
> so it allocate a buffer of len + 1 size. As result we should:
> * put 1 byte of modem status bits
> * increase data pointer
> * put "len" bytes of data
> but actually we have:
> * increase first byte with the value of modem status bits
> * decrease "len"
> * put orig_len - 1 bytes of data starting from the buffer beggining
> This is evidently wrong.
>
> Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy@gmail.com>

Acked-by: Alan Cox <alan@linux.intel.com>


\
 
 \ /
  Last update: 2011-09-27 12:53    [W:0.033 / U:0.732 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site