Messages in this thread | | | From | Bart Van Assche <> | Date | Fri, 23 Sep 2011 12:31:22 +0200 | Subject | Re: [PATCH 25/26] dynamic_debug: add pr_fmt_dbg() for dynamic_pr_debug |
| |
On Thu, Sep 22, 2011 at 10:57 PM, Joe Perches <joe@perches.com> wrote: > On Wed, 2011-09-21 at 15:55 -0600, jim.cromie@gmail.com wrote: >> dynamic_pr_debug can add module, function, file, and line selectively, > [] >> diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h > [] >> +#ifndef pr_fmt_dbg >> +#define pr_fmt_dbg(fmt) fmt >> +#endif > [] >> +#ifndef pr_fmt_dbg >> +#define pr_fmt_dbg(fmt) pr_fmt(fmt) >> +#endif > > This might better be placed in printk.h just > once. > > I think pr_fmt_debug is better than pr_fmt_dbg > because the function/macro is named pr_debug. > > Maybe add all the pr_<level> variants too because > some like to prefix __func__ to pr_err but not pr_info > etc. > > #ifndef pr_fmt_emerg > #define pr_fmt_emerg(fmt) pr_fmt(fmt) > #endif > #ifndef pr_fmt_crit > #define pr_fmt_crit(fmt) pr_fmt(fmt) > #endif > #ifndef pr_fmt_alert > #define pr_fmt_alert(fmt) pr_fmt(fmt) > #endif > #ifndef pr_fmt_err > #define pr_fmt_err(fmt) pr_fmt(fmt) > #endif > #ifndef pr_fmt_notice > #define pr_fmt_notice(fmt) pr_fmt(fmt) > #endif > #ifndef pr_fmt_warn > #define pr_fmt_warn(fmt) pr_fmt(fmt) > #endif > #ifndef pr_fmt_info > #define pr_fmt_info(fmt) pr_fmt(fmt) > #endif > #ifndef pr_fmt_debug > #define pr_fmt_debug(fmt) pr_fmt(fmt) > #endif
Hi Joe,
Are you sure it makes sense to introduce all these new macros ? Introducing pr_fmt_dbg() makes sense to me, but the usefulness of the macros proposed above is not clear to me.
Bart.
| |