lkml.org 
[lkml]   [2011]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] cpusets: allow PF_THREAD_BOUND kworkers to escape from a cpuset
On Fri, 23 Sep 2011, Mike Galbraith wrote:

> Done, your ACK added as well.
>
> kworkers can be born in a cpuset, leaving them adrift on an unsinkable ship.
> Allow them to be moved to the root cpuset so the cpuset can be destroyed.
>

Thanks Li for the cc since I introduced this flag.

Does this even work?

You've modified cpuset_can_attach() to allow the attach for the cgroup
interface, but the actual function that attaches the task in the cpuset
code should fail since it does set_cpus_allowed_ptr() which should return
-EINVAL because of the PF_THREAD_BOUND. That should have emitted a
WARN_ON() if this patch was tested.

kworkers can always move themselves to the root cpuset, so that's probably
the better way of handling this than requiring userspace to do so.

And it seems like the workqueue code has a comment specifically about cpu
hotplug and why changing their cpumask shouldn't be allowed that was added
by Tejun Heo in db7bccf45cb8 ("workqueue: reimplement CPU hotplugging
support using trustee"). So let's cc him here as well at his
non-kernel.org address.

> Signed-off-by: Mike Galbraith <efault@gmx.de>
> Acked-by: Li Zefan <lizf@cn.fujitsu.com>
>
> diff --git a/kernel/cpuset.c b/kernel/cpuset.c
> index 10131fd..b26f4c4 100644
> --- a/kernel/cpuset.c
> +++ b/kernel/cpuset.c
> @@ -1384,7 +1384,7 @@ static int cpuset_can_attach(struct cgroup_subsys *ss, struct cgroup *cont,
> * set_cpus_allowed_ptr() on all attached tasks before cpus_allowed may
> * be changed.
> */
> - if (tsk->flags & PF_THREAD_BOUND)
> + if (tsk->flags & PF_THREAD_BOUND && cont != cont->top_cgroup)
> return -EINVAL;
>
> return 0;


\
 
 \ /
  Last update: 2011-09-23 11:15    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site