lkml.org 
[lkml]   [2011]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] mm/page_cgroup.c: quiet sparse noise
From
On Fri, Sep 23, 2011 at 6:45 AM, H Hartley Sweeten
<hartleys@visionengravers.com> wrote:
> Quite the sparse noise:
>
> warning: symbol 'swap_cgroup_ctrl' was not declared. Should it be static?
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Paul Menage <paul@paulmenage.org>
> Cc: Li Zefan <lizf@cn.fujitsu.com>
> Cc: Balbir Singh <bsingharora@gmail.com>
> Cc: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
>
> ---
>
> diff --git a/mm/page_cgroup.c b/mm/page_cgroup.c
> index 6bdc67d..eead840 100644
> --- a/mm/page_cgroup.c
> +++ b/mm/page_cgroup.c
> @@ -357,7 +357,7 @@ struct swap_cgroup_ctrl {
>        spinlock_t      lock;
>  };
>
> -struct swap_cgroup_ctrl swap_cgroup_ctrl[MAX_SWAPFILES];
> +static struct swap_cgroup_ctrl swap_cgroup_ctrl[MAX_SWAPFILES];

Seems reasonable

Acked-by: Balbir Singh <bsingharora@gmail.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2011-09-23 07:55    [W:0.183 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site