Messages in this thread | | | Date | Thu, 22 Sep 2011 15:25:17 -0700 | From | Tony Lindgren <> | Subject | Re: [PATCH v3 3/3] OMAP3: Remove auto-selection of PMICs |
| |
* Kevin Hilman <khilman@ti.com> [110922 14:30]: > Abhilash K V <abhilash.kv@ti.com> writes: > > > The current implementation almost assumes that only > > almost? ;) > > > TWL4030/TWL5030/TWl6030 are (or can be) used with the > > OMAP processors. This is, however, not true. > > > > This patch removes the automatic selection of the PMIC > > from Kconfig. > > All currently used PMICs are now added to omap2plus_defconfig; > > I don't think adding them to omap2plus_defconfig is right either, as > those will get stripped out the next time that file is (re)generated. > > > any new PMIC that gets supported in future could now be > > enabled here rather than by changing Kconfig for > > ARCH_OMAP2PLUS_TYPICAL > > IMO, the right fix is to have the board Kconfig entries select the PMIC > being used on those boards. That is the only solution that will scale, > and also work when using 'make randconfig'.
Agreed.
Tony
| |