Messages in this thread | | | From | Robert Jarzmik <> | Subject | Re: [PATCH V4] mtd: Add DiskOnChip G3 support | Date | Thu, 22 Sep 2011 19:42:59 +0200 |
| |
Artem Bityutskiy <dedekind1@gmail.com> writes:
> Could you please re-base your driver on top of my l2 tree and fix > warnings 0 I get the following: Of course.
> BTW, the next step I'd do is to try to compile it with sparse, so you > could test this driver with sparse: Documentation/sparse.txt OK.
>> +#define doc_flashSequence(seq) \ >> +do { \ >> + doc_dbg("doc_flashSequence: %02x " #seq "\n", DoC_Seq_##seq); \ >> + doc_writeb(DoC_Seq_##seq, DoC_FlashSequence); \ >> +} while (0) >> + ...zip... > > Could you please turn these macros into 'static inline' function - this > is one of the modern patterns of kernel programming - we try to use > functions for better type checking. No sorry, that I cannot. If you look closely, the ##seq is not something you can convert with an inline function, neither the #seq.
-- Robert
| |