lkml.org 
[lkml]   [2011]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 30/57] dmaengine: irq: Remove IRQF_DISABLED
    Date
    Since commit [c58543c8: genirq: Run irq handlers with interrupts disabled],
    We run all interrupt handlers with interrupts disabled
    and we even check and yell when an interrupt handler
    returns with interrupts enabled (see commit [b738a50a:
    genirq: Warn when handler enables interrupts]).

    So now this flag is a NOOP and can be removed.

    Signed-off-by: Yong Zhang <yong.zhang0@gmail.com>
    Acked-by: Vinod Koul <vinod.koul@linux.intel.com>
    Acked-by: Linus Walleij <linus.walleij@linaro.org>
    ---
    drivers/dma/amba-pl08x.c | 2 +-
    drivers/dma/coh901318.c | 2 +-
    drivers/dma/shdma.c | 4 ++--
    3 files changed, 4 insertions(+), 4 deletions(-)

    diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c
    index cd8df7f..5337b69 100644
    --- a/drivers/dma/amba-pl08x.c
    +++ b/drivers/dma/amba-pl08x.c
    @@ -1866,7 +1866,7 @@ static int pl08x_probe(struct amba_device *adev, const struct amba_id *id)
    writel(0x000000FF, pl08x->base + PL080_ERR_CLEAR);
    writel(0x000000FF, pl08x->base + PL080_TC_CLEAR);

    - ret = request_irq(adev->irq[0], pl08x_irq, IRQF_DISABLED,
    + ret = request_irq(adev->irq[0], pl08x_irq, 0,
    DRIVER_NAME, pl08x);
    if (ret) {
    dev_err(&adev->dev, "%s failed to request interrupt %d\n",
    diff --git a/drivers/dma/coh901318.c b/drivers/dma/coh901318.c
    index 4234f41..1dd9455 100644
    --- a/drivers/dma/coh901318.c
    +++ b/drivers/dma/coh901318.c
    @@ -1506,7 +1506,7 @@ static int __init coh901318_probe(struct platform_device *pdev)
    if (irq < 0)
    goto err_no_irq;

    - err = request_irq(irq, dma_irq_handler, IRQF_DISABLED,
    + err = request_irq(irq, dma_irq_handler, 0,
    "coh901318", base);
    if (err) {
    dev_crit(&pdev->dev,
    diff --git a/drivers/dma/shdma.c b/drivers/dma/shdma.c
    index 7f49235..8c137d2 100644
    --- a/drivers/dma/shdma.c
    +++ b/drivers/dma/shdma.c
    @@ -1106,7 +1106,7 @@ static void sh_dmae_chan_remove(struct sh_dmae_device *shdev)
    static int __init sh_dmae_probe(struct platform_device *pdev)
    {
    struct sh_dmae_pdata *pdata = pdev->dev.platform_data;
    - unsigned long irqflags = IRQF_DISABLED,
    + unsigned long irqflags = 0,
    chan_flag[SH_DMAC_MAX_CHANNELS] = {};
    int errirq, chan_irq[SH_DMAC_MAX_CHANNELS];
    int err, i, irq_cnt = 0, irqres = 0, irq_cap = 0;
    @@ -1266,7 +1266,7 @@ static int __init sh_dmae_probe(struct platform_device *pdev)
    IORESOURCE_IRQ_SHAREABLE)
    chan_flag[irq_cnt] = IRQF_SHARED;
    else
    - chan_flag[irq_cnt] = IRQF_DISABLED;
    + chan_flag[irq_cnt] = 0;
    dev_dbg(&pdev->dev,
    "Found IRQ %d for channel %d\n",
    i, irq_cnt);
    --
    1.7.4.1


    \
     
     \ /
      Last update: 2011-09-21 11:37    [W:0.025 / U:123.656 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site