Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH 2/2] creds: __task_cred(current) doesn't need rcu_read_lock_held() | Date | Tue, 20 Sep 2011 17:19:11 +0100 |
| |
Oleg Nesterov <oleg@redhat.com> wrote:
> Change __task_cred(task) to accept "task == current" without > rcu_read_lock_held(). This is what current_cred() currently does, > and with this change __task_cred() becomes more flexible/usable. > > Signed-off-by: Oleg Nesterov <oleg@redhat.com>
NAK!
If you compare carefully:
> - rcu_dereference_protected(current->cred, 1)
and:
> - rcu_dereference_check(__t->real_cred, 0); \
you'll notice they aren't quite the same in one very fundamental way.
David
| |