lkml.org 
[lkml]   [2011]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 2/2] creds: __task_cred(current) doesn't need rcu_read_lock_held()
Date
Oleg Nesterov <oleg@redhat.com> wrote:

> Change __task_cred(task) to accept "task == current" without
> rcu_read_lock_held(). This is what current_cred() currently does,
> and with this change __task_cred() becomes more flexible/usable.
>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>

NAK!

If you compare carefully:

> - rcu_dereference_protected(current->cred, 1)

and:

> - rcu_dereference_check(__t->real_cred, 0); \

you'll notice they aren't quite the same in one very fundamental way.

David


\
 
 \ /
  Last update: 2011-09-20 18:23    [W:0.191 / U:0.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site