lkml.org 
[lkml]   [2011]   [Sep]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 00/13] [PATCH RFC] Paravirtualized ticketlocks
    On Fri, Sep 2, 2011 at 1:07 PM, Jeremy Fitzhardinge <jeremy@goop.org> wrote:
    >
    > I don't know whether that fastpath code is small enough to consider
    > inlining everywhere?

    No.

    There's no point in inlining something that ends up containing a
    conditional function call: gcc will have to effectively save/restore
    registers around that thing anyway, so you lose a lot of the
    advantages of inlining. So I think it's better done as an out-of-line
    function, which I thought we did for spinlocks anyway.

    Also, do you run with CONFIG_OPTIMIZE_SIZE? Without that, gcc should
    be smart enough to make a "likely()" case be a fall-through.

    Linus


    \
     
     \ /
      Last update: 2011-09-02 22:31    [W:0.022 / U:0.060 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site