lkml.org 
[lkml]   [2011]   [Sep]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 3/3] trace points: power: remove 'cpu_id' from trace_cpu_idle
    From
    Ming Lei, Thomas,

    Sorry if it is a bit late to jump in.

    On Mon, Aug 22, 2011 at 10:27 AM, Thomas Renninger <trenn@suse.de> wrote:
    > On Saturday, August 20, 2011 04:40:09 AM Ming Lei wrote:
    >> Hi,
    >>
    >> 2011/8/20 Thomas Renninger <trenn@suse.de>:
    >> > On Friday, August 19, 2011 05:04:04 PM tom.leiming@gmail.com wrote:
    >> >> From: Ming Lei <tom.leiming@gmail.com>
    >> >>
    >> >> This patch removes the 'cpu_id' parameter of the cpu_idle
    >> >> trace point, based on the ideas below:
    >> >>
    >> >> - the cpu_id which is passed to trace point is always the current
    >> >>   cpu
    >> > Are you sure this will always be true?
    >>
    >> It is sure at least now,  the only place to pass 'dev->cpu' is inside
    >> cpuidle_idle_call,
    > It was known that cpu_id is always the current cpu with current
    > implementation when this got introduced.
    > But the perf events API must not change back and forth for userspace
    > compatibility. Therefore the cpu_id was added in case
    > that future implementations want to pass info where the current cpu
    > is not the cpu which is sent to the sleep state.
    Agree. Let's keep the cpu_id field.

    >
    >> smp_processor_id() can't be used safely in preemptible context.
    > I expect the only side effect that could happen is that if smp_process_id
    > is interrupted you get the wrong core id on a cpu idle trace event.
    > This only happens if cpuidle is not used and even then should happen
    > very rarely, nothing to worry for a debug tool like that.
    > And it should get fixed if these idle functions get fully integrated into
    > cpuidle at some point of time.
    >
    >   Thomas
    >

    Regards,
    Jean
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-09-02 09:29    [W:0.040 / U:90.644 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site