lkml.org 
[lkml]   [2011]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [Security] [PATCH 2/2] taskstats: restrict access to user
    Linus Torvalds <torvalds@linux-foundation.org> writes:

    > On Mon, Sep 19, 2011 at 10:39 AM, Vasiliy Kulikov <segoon@openwall.com> wrote:
    >>
    >> Shouldn't it simply protect taskstats_user_cmd()?  You may still poll
    >> the counters with TASKSTATS_CMD_ATTR_PID/TASKSTATS_CMD_ATTR_TGID.
    >
    > Yeah, I wondered where I'd really want to hook it in, that was the
    > other option.
    >
    > However, one thing that I'm currently independently asking some
    > networking people is whether that patch guarantees anything at all: is
    > the netlink command even guaranteed to be run in the same context as
    > the person sending it?

    I don't know where that conversation is happening but since I have been
    involved rather heavily in netlink syncrhonously processing messages I
    will answer.

    > After all, it comes in as a packet of data. How synchronous is the
    > genetlink thing guaranteed to be in the first place?

    Yes. The netlink skb is guaranteed to be processed synchronously
    and in the senders process. So accessing current is guaranteed
    to be valid.

    I just confirmed my memory by reading the cod in 3.1-rc1

    > IOW, are *any* of those "check current capabilities/euid" approaches
    > really guaranteed to be valid? Are they valid today, will they
    > necessarily be valid in a year?

    They are valid until such time as someone as someone rearchitects
    netlink message processing.

    Several years ago it was decided that processing netlink messages
    syncrhonously so we could access current made for much simpler easier to
    understand kernel code, and most if not all of the netlink permissions
    checks now depend upon the fact that we process netlink messages
    synchronously.

    Eric
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-09-20 05:37    [W:0.024 / U:61.228 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site