lkml.org 
[lkml]   [2011]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC][PATCH 1/5] x86: Remove const_udelay() caring about which cpu var it uses
From
Date
On Mon, 2011-09-19 at 16:51 -0500, Christoph Lameter wrote:
> On Mon, 19 Sep 2011, Steven Rostedt wrote:
>
> > The __const_udelay() code originally used raw_smp_processor_id()
> > in its calculations for a delaying. Probably because if it were
> > to migrate, it would take much longer to do so than the requested
> > delay.
> >
> > Switch from this_cpu_read() to __this_cpu_read() to document that
> > the read is racy and we do not care.
>
> Is preemption disabled by all callers to __const_udelay?

Nope, because I triggered a splat with it :-) From lots of places.

-- Steve




\
 
 \ /
  Last update: 2011-09-20 01:33    [from the cache]
©2003-2011 Jasper Spaans