Messages in this thread | | | From | "Luck, Tony" <> | Date | Mon, 19 Sep 2011 13:23:35 -0700 | Subject | RE: [PATCH v2] Fix EDAC sdram_scrub_rate read/write failure |
| |
> @Tony, do you think the above makes sense? Anything against changing > that part of the EDAC API to say:
> Sdram memory scrubbing rate:
> If configuration fails or memory scrubbing is not implemented, > the access to that attribute from userspace will fail.
Ideally we'd not have the file there at all if memory scrubbing isn't implemented.
I like having the write fail if the driver cannot set the chosen scrub rate ... though there seems to be some wiggle room ... scrub rates aren't exact, the user can try to set one and then read back to find out what the rate was actually rounded to. If you have to read back anyway, then reading back to find out if you failed doesn't look quite so odd (still odd, but with some sort of logic).
-Tony
| |