lkml.org 
[lkml]   [2011]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/9] Remove parent field in cpuacct cgroup
From
Date
On Wed, 2011-09-14 at 17:04 -0300, Glauber Costa wrote:
> + for (; ca; ca = parent_ca(ca)) {

It might be good to check that the loop condition and null condition in
the parent_ca() function get folded. Otherwise there's a double branch
in that loop.

Note that this function is one of the reasons I dislike cpuacct, it adds
a second cgroup hierarchy traversal to every context switch.

Cache-miss heaven all this.


\
 
 \ /
  Last update: 2011-09-19 18:05    [from the cache]
©2003-2011 Jasper Spaans