lkml.org 
[lkml]   [2011]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] mfd: Combine MFD_SUPPORT and MFD_CORE
    Date
    On Thursday 15 September 2011, Grant Likely wrote:
    > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
    > > index 21574bd..1836cdf 100644
    > > --- a/drivers/mfd/Kconfig
    > > +++ b/drivers/mfd/Kconfig
    > > @@ -2,10 +2,9 @@
    > > # Multifunction miscellaneous devices
    > > #
    > >
    > > -menuconfig MFD_SUPPORT
    > > - bool "Multifunction device drivers"
    > > +menuconfig MFD_CORE
    > > + tristate "Multifunction device drivers"
    > > depends on HAS_IOMEM
    > > - default y
    >
    > Looks like there is a bug here. Kconfig symbols with dependencies
    > (HAS_IOMEM) must not ever be selected by other symbols because Kconfig
    > doesn't implement a way to resolve them. This patch means that every
    > "select MFD_CORE" just assumes that HAS_IOMEM is also selected.

    That is probably a fair assumption though. Almost all architectures
    set HAS_IOMEM unconditionally, and the other ones (probably just s390)
    would not select MFD_CORE.

    Note that Samuel already took the other patch in the end, so it doesn't
    matter. The patch I posted encloses the entire directory in "if HAS_IOMEM".

    Arnd


    \
     
     \ /
      Last update: 2011-09-19 17:09    [W:0.022 / U:30.012 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site