lkml.org 
[lkml]   [2011]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH 1/3] Staging: hv: util: Perform some service specific init/deinit in probe/remove
    Date


    > -----Original Message-----
    > From: Joe Perches [mailto:joe@perches.com]
    > Sent: Sunday, September 18, 2011 1:53 PM
    > To: KY Srinivasan
    > Cc: gregkh@suse.de; linux-kernel@vger.kernel.org;
    > devel@linuxdriverproject.org; virtualization@lists.osdl.org; Haiyang Zhang
    > Subject: Re: [PATCH 1/3] Staging: hv: util: Perform some service specific
    > init/deinit in probe/remove
    >
    > On Sun, 2011-09-18 at 10:31 -0700, K. Y. Srinivasan wrote:
    > > In preparation for modifying the util driver to fully conform to the
    > > Linux Driver Model,
    > []
    > > diff --git a/drivers/staging/hv/hv_util.c b/drivers/staging/hv/hv_util.c
    > []
    > > static const struct hv_vmbus_device_id id_table[] = {
    > > /* Shutdown guid */
    > > { VMBUS_DEVICE(0x31, 0x60, 0x0B, 0X0E, 0x13, 0x52, 0x34, 0x49,
    > > - 0x81, 0x8B, 0x38, 0XD9, 0x0C, 0xED, 0x39, 0xDB) },
    > > + 0x81, 0x8B, 0x38, 0XD9, 0x0C, 0xED, 0x39, 0xDB)
    > > + .driver_data = (unsigned long)&util_shutdown },
    >
    > Isn't this a kernel_ulong_t ?

    Yes; but kernel_ulong_t is unsigned long and this code is compiled only in the kernel.

    Regards,

    K. Y

    >
    > > + .driver_data = (unsigned long)&util_timesynch },
    >
    > etc.
    >
    >

    \
     
     \ /
      Last update: 2011-09-19 00:29    [W:0.023 / U:0.860 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site