lkml.org 
[lkml]   [2011]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/7] Basic kernel memory functionality for the Memory Controller
On Sun, Sep 18, 2011 at 04:11:21PM -0300, Glauber Costa wrote:
> On 09/18/2011 04:05 PM, Kirill A. Shutemov wrote:
> > On Sun, Sep 18, 2011 at 12:39:12AM -0300, Glauber Costa wrote:
> >>> Always zero in root cgroup?
> >>
> >> Yes, if we're not accounting, it should be zero. WARN_ON, maybe?
> >
> > -ENOSYS?
> >
> I'd personally prefer WARN_ON. It is good symmetry from userspace PoV to
> always be able to get a value out of it. Also, it something goes wrong
> and it is not zero for some reason, this will help us find it.

What's the point to get non-relevant value?
What about -ENOSYS + WARN_ON?

--
Kirill A. Shutemov


\
 
 \ /
  Last update: 2011-09-18 22:41    [from the cache]
©2003-2011 Jasper Spaans