Messages in this thread | | | Date | Sun, 18 Sep 2011 15:59:57 -0400 | From | Christoph Hellwig <> | Subject | Re: [PATCH] Return -EIO when xfs_vn_getattr() failed |
| |
On Sat, Sep 17, 2011 at 10:38:38PM +0900, Mitsuo Hayasaka wrote: > An attribute of inode can be fetched via xfs_vn_getattr() in XFS. > Currently it returns EIO, not negative value, when it failed. > As a result, the system call returns not negative value even though > an error occured. The stat(2), ls and mv commands cannot handle this > error and do not work correctly. > > This patch fixes this bug, and returns -EIO, not EIO when an error > is detected in xfs_vn_getattr().
Indeed. Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
| |