lkml.org 
[lkml]   [2011]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/7] BTRFS: Fix lseek return value for error
> > with an additional improvement if the offset is larger or equal to the
> > file size, return -ENXIO in directly:
> >
> > if (offset >= inode->i_size) {
> > mutex_unlock(&inode->i_mutex);
> > return -ENXIO;
> > }
>
> Except that is wrong, because it would then be impossible to write sparse files.

And also i_size must be always read with i_size_read()

Anyways clearly there's a problem in btrfs land with merging fixes in time.
Is anyone collecting patches while Chris is gone?

-Andi



\
 
 \ /
  Last update: 2011-09-18 03:49    [W:0.115 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site