Messages in this thread | | | Date | Sat, 17 Sep 2011 18:46:08 -0700 | From | Andi Kleen <> | Subject | Re: [PATCH 1/7] BTRFS: Fix lseek return value for error |
| |
> > with an additional improvement if the offset is larger or equal to the > > file size, return -ENXIO in directly: > > > > if (offset >= inode->i_size) { > > mutex_unlock(&inode->i_mutex); > > return -ENXIO; > > } > > Except that is wrong, because it would then be impossible to write sparse files.
And also i_size must be always read with i_size_read()
Anyways clearly there's a problem in btrfs land with merging fixes in time. Is anyone collecting patches while Chris is gone?
-Andi
| |